-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Pin kindest/node images to known good versions in clusterctl upgrade tests #8860
🐛 Pin kindest/node images to known good versions in clusterctl upgrade tests #8860
Conversation
/test pull-cluster-api-e2e-full-main |
92e20d4
to
c60992e
Compare
c60992e
to
d66f6aa
Compare
/hold To revert the PR-Informing changes. |
/retitle 🐛 Pin KIND nodes images to known good versions |
d66f6aa
to
3c0c11a
Compare
3c0c11a
to
a25b0b2
Compare
/hold remove |
/retest |
/test pull-cluster-api-e2e-full-main |
ef55aaf
to
477e309
Compare
/test pull-cluster-api-e2e-full-main |
477e309
to
dfe0daf
Compare
/test pull-cluster-api-e2e-full-main |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
dfe0daf
to
3e77da7
Compare
/test pull-cluster-api-e2e-full-main |
valueFrom: | ||
template: | | ||
kindest/node:{{ .builtin.controlPlane.version | replace "+" "_" }} | ||
- selector: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These patches should be reverted once we have kindest/node version resolution in CAPD.
Thank you very much!! /lgtm |
LGTM label has been added. Git tree hash: 66fd0bfe27293feb4b2ff3352db3d23dd9ddb0c7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/area e2e-testing |
Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0
This should fix test failures related to #8815