🐛 Pin kindest/node images to known good versions in clusterctl upgrade tests #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-full-main |
k8s-ci-robot
added
size/M
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
2 times, most recently
from
92e20d4
to
c60992e
Compare
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
from
c60992e
to
d66f6aa
Compare
|
/hold To revert the PR-Informing changes. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/retitle 🐛 Pin KIND nodes images to known good versions |
k8s-ci-robot
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
from
d66f6aa
to
3c0c11a
Compare
sbueringer
reviewed
Jun 15, 2023
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
from
3c0c11a
to
a25b0b2
Compare
|
/hold remove |
|
/retest |
|
/test pull-cluster-api-e2e-full-main |
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
2 times, most recently
from
ef55aaf
to
477e309
Compare
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-e2e-full-main |
killianmuldoon
changed the title
killianmuldoon
commented
Jun 15, 2023
sbueringer
reviewed
Jun 15, 2023
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
from
477e309
to
dfe0daf
Compare
|
/test pull-cluster-api-e2e-full-main |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-pin-kind-sha-0.4-1.0
branch
from
dfe0daf
to
3e77da7
Compare
|
/test pull-cluster-api-e2e-full-main |
killianmuldoon
commented
Jun 15, 2023
| valueFrom: | ||
| template: | | ||
| kindest/node:{{ .builtin.controlPlane.version | replace "+" "_" }} | ||
| - selector: |
There was a problem hiding this comment.
These patches should be reverted once we have kindest/node version resolution in CAPD.
|
Thank you very much!! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 66fd0bfe27293feb4b2ff3352db3d23dd9ddb0c7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/area e2e-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0
This should fix test failures related to #8815