-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8868
[release-1.4] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area e2e-testing
/test pull-cluster-api-e2e-full-main |
@killianmuldoon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-release-1.4 |
@killianmuldoon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-release-1-4 |
Changes look good to me /lgtm /hold |
LGTM label has been added. Git tree hash: 4aa855bfdb505ff4d02071901964b61292cc2a51
|
0be7e1e
to
15cd04c
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
/lgtm |
LGTM label has been added. Git tree hash: 1b70c8cbccc725193c9abbd75292d69a279c7ac1
|
/close This approach isn't going to work. Will look to also revert this on main. |
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/reopen |
@killianmuldoon: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-release-1-4 |
15cd04c
to
06dc56f
Compare
06dc56f
to
99d8afa
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
99d8afa
to
1eadeff
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
1eadeff
to
493d7e7
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
493d7e7
to
d19b2a6
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
d19b2a6
to
bf4dc07
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
/retest |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
bf4dc07
to
e4c5382
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
Thank you very much! /lgtm |
LGTM label has been added. Git tree hash: eaaea2dde05dc4712a03a7f9b1740402b5e29b6e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0
This should fix test failures related to #8815