Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8868

Merged

Conversation

killianmuldoon
Copy link
Contributor

Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0

This should fix test failures related to #8815

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2023
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Jun 16, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-4
  • /test pull-cluster-api-e2e-release-1-4
  • /test pull-cluster-api-test-mink8s-release-1-4
  • /test pull-cluster-api-test-release-1-4
  • /test pull-cluster-api-verify-release-1-4

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-4
  • /test pull-cluster-api-e2e-full-release-1-4
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-4
  • /test pull-cluster-api-e2e-informing-release-1-4
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-4
  • pull-cluster-api-build-release-1-4
  • pull-cluster-api-e2e-informing-ipv6-release-1-4
  • pull-cluster-api-e2e-informing-release-1-4
  • pull-cluster-api-e2e-release-1-4
  • pull-cluster-api-test-mink8s-release-1-4
  • pull-cluster-api-test-release-1-4
  • pull-cluster-api-verify-release-1-4

In response to this:

/test pull-cluster-api-e2e-full-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1.4

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-4
  • /test pull-cluster-api-e2e-release-1-4
  • /test pull-cluster-api-test-mink8s-release-1-4
  • /test pull-cluster-api-test-release-1-4
  • /test pull-cluster-api-verify-release-1-4

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-4
  • /test pull-cluster-api-e2e-full-release-1-4
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-4
  • /test pull-cluster-api-e2e-informing-release-1-4
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-4
  • pull-cluster-api-build-release-1-4
  • pull-cluster-api-e2e-informing-ipv6-release-1-4
  • pull-cluster-api-e2e-informing-release-1-4
  • pull-cluster-api-e2e-release-1-4
  • pull-cluster-api-test-mink8s-release-1-4
  • pull-cluster-api-test-release-1-4
  • pull-cluster-api-verify-release-1-4

In response to this:

/test pull-cluster-api-e2e-full-release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@sbueringer
Copy link
Member

Changes look good to me

/lgtm
/approve

/hold
given you wanted to take a look at CI / the test is failed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4aa855bfdb505ff4d02071901964b61292cc2a51

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b70c8cbccc725193c9abbd75292d69a279c7ac1

@killianmuldoon
Copy link
Contributor Author

/close

This approach isn't going to work. Will look to also revert this on main.

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closed this PR.

In response to this:

/close

This approach isn't going to work. Will look to also revert this on main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@killianmuldoon
Copy link
Contributor Author

/retest

Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-4

@sbueringer
Copy link
Member

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eaaea2dde05dc4712a03a7f9b1740402b5e29b6e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@killianmuldoon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 544894a into kubernetes-sigs:release-1.4 Jun 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants