-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add kind mapper #8880
🐛 Add kind mapper #8880
Conversation
Part of #8788 |
257757a
to
fb82cdb
Compare
/retest |
1 similar comment
/retest |
/test pull-cluster-api-e2e-full-main |
9f5e993
to
1ba69ac
Compare
/retest |
/lgtm |
LGTM label has been added. Git tree hash: 4f7268ebdbeae84082df83711991d309aee15008
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits and one question about simplifying the customImage
handling.
|
||
kindMapping := kind.GetMapping(semVer) | ||
|
||
// Use custom image if provided. | ||
if image != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative here would be to always use the kind mapping when the image is in the form kindest/node:vX.X.X
. I'm in favor of this as the current version means adding the same tag in the custom image has different behaviour than a machine that appears to be using that image. I think this could also simplify the logic in nodepool - but I haven't looked closely at that code yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
/test pull-cluster-api-e2e-full-main |
/lgtm /assign @killianmuldoon |
LGTM label has been added. Git tree hash: 2d119ca115b23eef95cd6f1292d6957015c453aa
|
/hold /lgtm |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.3 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8901f5f
to
7a4e06c
Compare
/hold cancel |
@killianmuldoon: #8880 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: #8880 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area provider/infrastructure-docker |
What this PR does / why we need it:
CAPD doesn't have direct dependencies from Kind, however, it is using kindest/node images.
As a consequence CAPD must stay in sync with Kind with regards to how kindest/node images are run when creating a new DockerMachine.
kindest/node images are created using a specific Kind version, and thus it is required to keep into account the mapping between the Kubernetes version for a kindest/node and the Kind version that created that image, so we can run it properly.
This PR implements this mapping and use it to pick the right image to use and to start this image as expected.
Which issue(s) this PR fixes:
Fixes #