Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Use rest config from ClusterCacheTracker consistently #8894

Merged
merged 1 commit into from
Jun 22, 2023
Merged

🌱 Use rest config from ClusterCacheTracker consistently #8894

merged 1 commit into from
Jun 22, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon @ykakarap

@sbueringer sbueringer force-pushed the pr-use-restconfig-from-cct-consistently branch from 38b680e to 970ae7f Compare June 21, 2023 09:17
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2023
killianmuldoon
killianmuldoon reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f2f78a24ac1ebf0fab830ac8919ac786926ca93

@sbueringer
Use rest config from ClusterCacheTracker consistently
a37f57d 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-use-restconfig-from-cct-consistently branch from 970ae7f to a37f57d Compare June 21, 2023 09:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2023
@sbueringer sbueringer mentioned this pull request Jun 21, 2023
Open
27 tasks
@sbueringer
Copy link
Member Author

Had to fix a unit test

@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9f7bfc72f017db5c53c61c443de51f2dd33da9ef

@sbueringer sbueringer mentioned this pull request Jun 21, 2023
Closed
killianmuldoon
killianmuldoon reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@killianmuldoon
Copy link
Contributor

Feel free to remove /hold when you're happy this is ready.

@fabriziopandini
Copy link
Member

/lgtm
feel free to unhold

@sbueringer one question:
should we deprecate NewClusterClient and RESTConfig (and make them private in a follow-up release), so we prevent issues like this to pop back in the future?

@sbueringer
Copy link
Member Author

sbueringer commented Jun 22, 2023 •
edited

/lgtm feel free to unhold

@sbueringer one question: should we deprecate NewClusterClient and RESTConfig (and make them private in a follow-up release), so we prevent issues like this to pop back in the future?

Sounds reasonable to me at a first glance. I would prefer not having to maintain them anymore. But I don't know who is using them and maybe they don't want to use the CCT. For example in a CLI folks might just want to get a rest config for a cluster and then don't want to run an entire CCT for that

(Btw NewClusterClient is not used at all anymore in core CAPI)

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 00469fa into kubernetes-sigs:main Jun 22, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 22, 2023
@sbueringer sbueringer deleted the pr-use-restconfig-from-cct-consistently branch June 22, 2023 08:43
@killianmuldoon
Copy link
Contributor

/area clustercachetracker

@k8s-ci-robot k8s-ci-robot added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@richardcase richardcase Awaiting requested review from richardcase

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@richardcase richardcase

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sbueringer @k8s-ci-robot @richardcase @killianmuldoon @fabriziopandini @ykakarap