-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/e2e/in-memory: improve performance by fixing locking issues #8895
Conversation
key, err := certs.NewPrivateKey() | ||
var key *rsa.PrivateKey | ||
|
||
func init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating a private key is slow. Now we only do it once on startup and share it across clusters
m.log.Error(startErr, "Failed to start WorkloadClusterListener", "listenerName", wclName, "address", wcl.Address()) | ||
// Wait until the sever is working. | ||
var pollErr error | ||
err = wait.PollUntilContextTimeout(context.TODO(), 10*time.Millisecond, 1*time.Second, true, func(ctx context.Context) (done bool, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change we wait until the listener serves (at least a tls handshake). This is quicker than always waiting 100 ms
Signed-off-by: Stefan Büringer buringerst@vmware.com
3f136e3
to
245e305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for moving forward this change!
LGTM label has been added. Git tree hash: 7f6f978ad91e61315f0694c16b486c0dfb11666f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/infrastructure-in-memory |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Currently the in-memory provider gets slow if we're getting to very high cluster numbers.
Basically the problem was that when we create a new apiserver we locked the global lock. This was slowing down all requests served by the apiserver because that lock is used during every tls handshake and in every request (to get the resourceGroup).
Kudos to @fabriziopandini for the collaboration on this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #8814