-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update KIND to v0.20.0 #8908
🌱 Update KIND to v0.20.0 #8908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The CAPI K8s upgrade tests are currently failing because we are always building the latest version of the image with KIND 0.19.0, but trying to run them with KIND_MODE=v0.20.0 due to the behaviour of the KIND mapper.
I'm hopeful we won't have the same kinds of build issues in the future, but there's an order of operations problem with those tests combined with the KIND_MAPPER.
An possible solution (upstream in KIND) would be to add a label to the images with the KIND build version, not sure if that would be accepted upstream though.
/test ? |
@killianmuldoon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
e0a1b73
to
db72647
Compare
/test pull-cluster-api-e2e-full-main |
Change sounds reasonable to me, especially to get back to green. /lgtm /hold |
LGTM label has been added. Git tree hash: 5ca94f06de5fefb569b25d2e2909e67b1172143b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold remove e2e now passing |
/hold cancel 🙃 |
/area dependency |
Update KIND to v0.20.0.
Release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0
There was some changes in the
kindest/node
build process in this release which caused additional work to adopt it. See more under issue #8788.Fixes #8788