Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add improvements to scale e2e #8910

Merged
merged 1 commit into from
Jun 29, 2023
Merged

🌱 add improvements to scale e2e #8910

merged 1 commit into from
Jun 29, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR adds the following improvements to the scale E2E test:

  • ability to set MachineDeployment count
  • ability to skip clean up
  • ability to skip waiting for cluster creation
  • always use the same namespace for scale testing (this is primarily for the benefit of easy debuggability)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2023
fabriziopandini
fabriziopandini reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits

test/e2e/scale.go Show resolved Hide resolved
test/e2e/scale.go Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
sbueringer
sbueringer reviewed Jun 27, 2023
View reviewed changes
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Show resolved Hide resolved
test/e2e/scale.go Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
@ykakarap
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
  • /test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-scale-main-experimental

sbueringer
sbueringer reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise lgtm from my side

test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-scale-main-experimental

@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c9ddeb47c0aa7f2eaaeead7c25db0356da77fceb

fabriziopandini
fabriziopandini reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@fabriziopandini
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 916b187 into kubernetes-sigs:main Jun 29, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 29, 2023
@killianmuldoon
Copy link
Contributor

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ykakarap @k8s-ci-robot @sbueringer @fabriziopandini @killianmuldoon