-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 KCP: cache secrets between LookupOrGenerate and ensureCertificatesOwnerRef #8926
🌱 KCP: cache secrets between LookupOrGenerate and ensureCertificatesOwnerRef #8926
Conversation
56ae244
to
36a1f46
Compare
/assign @fabriziopandini @killianmuldoon @ykakarap /hold |
@@ -93,6 +93,9 @@ func TestGetWorkloadCluster(t *testing.T) { | |||
ObjectMeta: metav1.ObjectMeta{ | |||
Name: "my-cluster-etcd", | |||
Namespace: ns.Name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is pretty much unrelated to the rest of the PR. Just some test cleanup of some issues that I found while evalutating an alternative solution to the current PR (same for suite_test.go)
/area provider/control-plane-kubeadm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1b5bb4c8fa439f9a0648fe4427726efbb389a8d1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit. If I understand right the Get
on Secret is always uncached because Secrets aren't cached in KCP - so this change instead stores the secret somewhere we have ready access to it.
…erRef Signed-off-by: Stefan Büringer buringerst@vmware.com
36a1f46
to
d22e7ce
Compare
Yes exactly. That's the idea. Just a small optimization because actually caching the secrets is not that trivial (because currently there is no way to identify which secrets exactly to cache and we don't want to cache all). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: b26bf0459362b80665f037ea3da73e07ab9dbcf5
|
/hold In case someone else wants to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
feel free to un-hold anytime
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thx for the reviews! /hold cancel |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #8814