-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🌱 Set Kubelet args internally in CAPD #8929
[release-1.4] 🌱 Set Kubelet args internally in CAPD #8929
Conversation
/area provider/infrastructure-docker |
/hold |
@killianmuldoon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-release-1-4 |
2da1aa8
to
ef3ae0a
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
(cherry picked from commit 8b15bc0)
ef3ae0a
to
f1c8be2
Compare
/test pull-cluster-api-e2e-full-release-1-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diffed the PR against main. Almost everything as expected. One question about the ClusterClass
/lgtm |
LGTM label has been added. Git tree hash: 5dda4fd757f1321268e27db49e52ff1f75bb9633
|
(cherry picked from commit 0b0695b)
f1c8be2
to
ef7b6e6
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: a70b1b1e4de28d86696f1b8b5bfbea9deffcc431
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest |
Manual cherry-pick of #8921 and #8881
What this PR does / why we need it:
This PR is a follow up of #8881 automatic generation of another kubeletExtraArg and dropping corresponding code from templates all around.
The PS also includes the cleanup of the kubeletExtraArgs from the cmd/clusterctl/client/cluster/assets folder, which I forgot in the previous PR