🌱 Protect well know registry from accidental push during tilt up #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/S
fabriziopandini
force-pushed
the
protect-well-known-registry-during-tilt-up
branch
from
e6a1637
to
d382fb0
Compare
k8s-ci-robot
added
the
cncf-cla: yes
sbueringer
reviewed
Jun 29, 2023
fabriziopandini
force-pushed
the
protect-well-known-registry-during-tilt-up
branch
from
d382fb0
to
dc87b86
Compare
sbueringer
reviewed
Jul 3, 2023
fabriziopandini
force-pushed
the
protect-well-known-registry-during-tilt-up
branch
from
dc87b86
to
f192b7b
Compare
sbueringer
reviewed
Jul 7, 2023
|
Sorry last one :) |
fabriziopandini
force-pushed
the
protect-well-known-registry-during-tilt-up
branch
2 times, most recently
from
856a2d0
to
54586ea
Compare
fabriziopandini
force-pushed
the
protect-well-known-registry-during-tilt-up
branch
from
54586ea
to
cb5f429
Compare
|
Tested locally. All works! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9be614ecf4d3a40e0920e3c4535db2cdf62b34fc
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/area devtools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes sure that if you are using tilt up without a local registry, you can't accidentally push to well know repository like our staging repo
cc @sbueringer