Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 hack/observability: skip preload images on non-kind clusters #8931

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 28, 2023

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2023
@sbueringer
Copy link
Member Author

@sbueringer sbueringer changed the title 🌱 hack/observability: add flag to disable cert-manager image preload 🌱 hack/observability: add flag to allow disabling cert-manager image preload Jun 28, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one nit

hack/tools/tilt-prepare/main.go Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-disable-cert-manager-preload branch from 0245cf4 to 1c8d3a3 Compare June 28, 2023 17:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2023
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-disable-cert-manager-preload branch from 1c8d3a3 to 598a10b Compare June 28, 2023 17:48
@sbueringer
Copy link
Member Author

@fabriziopandini @killianmuldoon PTAL :)

(cc @ykakarap pushed the same version on the scale branch, so the flag is not needed anymore)

@sbueringer sbueringer changed the title 🌱 hack/observability: add flag to allow disabling cert-manager image preload 🌱 hack/observability: skip preload images on non-kind clusters Jun 28, 2023
@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2473293dd7a183515bf90a7a2b56ec2a0faf1396

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5730e77 into kubernetes-sigs:main Jun 29, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 29, 2023
@sbueringer sbueringer deleted the pr-disable-cert-manager-preload branch June 29, 2023 08:29
@killianmuldoon
Copy link
Contributor

/area devtools

@k8s-ci-robot k8s-ci-robot added the area/devtools Issues or PRs related to devtools label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants