-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 all: only set finalizers if deletionTimestamp is not set #8949
🐛 all: only set finalizers if deletionTimestamp is not set #8949
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/test pull-cluster-api-e2e-full-main |
cc @enxebre given somewhat related discussion last week around Machine finalizer |
Make sense to me. Alternatively we could move up reconcile deletion logic to run before Add finalizer logic |
I think moving the finalizer down or the reconcileDelete up is in most cases the same change :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 68d5b76224ea18a74178743f2525b1b02dec0dfa
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area api |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
As reported in #8946 Cluster API today tries to add a finalizer even if objects already has a deletionTimestamp set.
This results in the following error message from the APIserver:
This case especially occurs if a finalizer of another controller is removed after our finalizer.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #8946