-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Adjust MinReadySeconds docs to reality #8956
Conversation
f18003c
to
3e7e4f6
Compare
/lgtm |
LGTM label has been added. Git tree hash: b30c4a172dece01c17e435b0c714dd27f4210d30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area documentation |
What this PR does / why we need it:
Adjust MinReadySeconds docs to reality
cluster-api/internal/controllers/machineset/machineset_controller.go
Lines 887 to 891 in 730f63d
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #