Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add tuning guide #8958

Merged
merged 1 commit into from
Jul 5, 2023
Merged

📖 Add tuning guide #8958

merged 1 commit into from
Jul 5, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR wraps up lessons learned while working on #8814, capturing also some notes about where we are and what we are still missing in our setup for allowing follow-up iterations on performance tuning.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2023
sbueringer
sbueringer reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great summary!

docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
docs/book/src/developer/architecture/controllers/tuning.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for squash and in case someone else wants to take a look

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 413026468222ec5a31fe521a4a2ffe42caba528e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@fabriziopandini
Copy link
Member Author

squashed

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 43f1c49 into kubernetes-sigs:main Jul 5, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jul 5, 2023
@sbueringer
Copy link
Member

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 5, 2023
Closed
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #8968

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the tuning-guide branch July 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot