-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/e2e: add field to scale test to deploy Clusters in separate namespace #8963
🌱 test/e2e: add field to scale test to deploy Clusters in separate namespace #8963
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-scale-main-experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two nits from my side
68039e1
to
cf9ead6
Compare
@fabriziopandini PTAL. Fixed / answered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Code looks good - will run this locally probably tomorrow to see how it performs.
LGTM label has been added. Git tree hash: ca625626fd4fd26845c07be756bc689bdf8ad35b
|
/hold realized I missed the delete part |
cf9ead6
to
fabdb44
Compare
Fixed the deletion part Tested the multi-ns case locally. Testing the regular one via /hold cancel |
fabdb44
to
c54b0a0
Compare
c54b0a0
to
065082d
Compare
/test pull-cluster-api-e2e-scale-main-experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 9acc8170038c08cb27c8a91730614352e68f259c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
CI green /hold cancel |
/area e2e-testing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #8814