Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test/e2e: add field to scale test to deploy Clusters in separate namespace #8963

Merged
merged 1 commit into from
Jul 7, 2023
Merged

🌱 test/e2e: add field to scale test to deploy Clusters in separate namespace #8963

merged 1 commit into from
Jul 7, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jul 5, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #8814

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2023
@sbueringer sbueringer changed the title test/e2e: add field to scale test to deploy Clusters in separate namespace 🌱 test/e2e: add field to scale test to deploy Clusters in separate namespace Jul 5, 2023
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
  • /test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-scale-main-experimental

fabriziopandini
fabriziopandini reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two nits from my side

test/e2e/scale.go Outdated Show resolved Hide resolved
test/e2e/scale.go Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-scale-e2e-tests-multi-ns branch from 68039e1 to cf9ead6 Compare July 5, 2023 14:44
@sbueringer
Copy link
Member Author

@fabriziopandini PTAL. Fixed / answered

killianmuldoon
killianmuldoon reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Code looks good - will run this locally probably tomorrow to see how it performs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca625626fd4fd26845c07be756bc689bdf8ad35b

@sbueringer
Copy link
Member Author

/hold

realized I missed the delete part

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@sbueringer sbueringer force-pushed the pr-scale-e2e-tests-multi-ns branch from cf9ead6 to fabdb44 Compare July 6, 2023 10:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2023
@sbueringer
Copy link
Member Author

Fixed the deletion part

Tested the multi-ns case locally. Testing the regular one via
/test pull-cluster-api-e2e-scale-main-experimental

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
@sbueringer sbueringer force-pushed the pr-scale-e2e-tests-multi-ns branch from fabdb44 to c54b0a0 Compare July 7, 2023 09:48
@sbueringer sbueringer force-pushed the pr-scale-e2e-tests-multi-ns branch from c54b0a0 to 065082d Compare July 7, 2023 09:51
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-scale-main-experimental

killianmuldoon
killianmuldoon reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9acc8170038c08cb27c8a91730614352e68f259c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@killianmuldoon
Copy link
Contributor

/hold
for ci

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@sbueringer
Copy link
Member Author

CI green

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 89bbf6a into kubernetes-sigs:main Jul 7, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jul 7, 2023
@sbueringer sbueringer deleted the pr-scale-e2e-tests-multi-ns branch July 7, 2023 10:19
@johannesfrey
Copy link
Contributor

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbueringer @k8s-ci-robot @killianmuldoon @johannesfrey @fabriziopandini