-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add SHA to default KIND image used in e2e tests #8975
🌱 Add SHA to default KIND image used in e2e tests #8975
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If I got it correctly in core CAPI we never use this default version. Is there a way we can verify that it works? (manually is okay) |
This works as expected locally. If I change the sha to an invalid one and do not set the management cluster Kubernetes verison the kind cluster fails to come up. With this SHA - i.e. the one from the KIND |
Perfect, thx! /lgtm |
LGTM label has been added. Git tree hash: 16d06c3b58795a479ad23cdb3e5ebcadbadce033
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: new pull request created: #8976 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area e2e-testing |
Add a SHA to the default KIND image used for bootstrapping a cluster for the e2e tests.
Ref: #8974 (comment)