-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add CABPOCNE and CACPOCNE Providers #9012
🌱 Add CABPOCNE and CACPOCNE Providers #9012
Conversation
Welcome @theabmitra! |
Hi @theabmitra. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm Please squash the commits |
LGTM label has been added. Git tree hash: 6122374cf96c0ac5c4c33ce7e21c990bf3f3c8a9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a tiny nit from my side, otherwise lgtm for me
…otstrapProviderName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending squash
@theabmitra can you squash the commits? |
Let's use squash to get this into the release /lgtm |
LGTM label has been added. Git tree hash: e1f4ee483d13c9f081092891ece21ffc2fae115e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer will this be available as part of 1.5 release or 1.6 ? |
/cherry-pick release-1.5 1.5 |
@sbueringer: new pull request created: #9068 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* OCNE bootstrap and control plane changes * fix line spaces * reimport gomega * reimport gomega in config test * Rearrange OCNE to alphabetical and add more test data * Rename variable name OCNEBootstrapProviderName to OracleCloudNativeBootstrapProviderName
@killianmuldoon and @sbueringer i see that 1.5 has been released but i don't see this fix reflected in the docs nor in the list for Bug Fixes/ New features |
Docs should be there now. It's not in bug fixes / new features because we used squash. I'll add it manually now (cc @joekr @killianmuldoon just fyi) |
* OCNE bootstrap and control plane changes * fix line spaces * reimport gomega * reimport gomega in config test * Rearrange OCNE to alphabetical and add more test data * Rename variable name OCNEBootstrapProviderName to OracleCloudNativeBootstrapProviderName
What this PR does / why we need it:
Adding the CAPI bootstrap and control plane provider for Oracle Cloud Native Environment (OCNE) https://github.com/verrazzano/cluster-api-provider-ocne
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):No currently open issues this addresses