-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🐛 requeue KCP object if ControlPlaneComponentsHealthyCondition is not yet true #9036
[release-1.4] 🐛 requeue KCP object if ControlPlaneComponentsHealthyCondition is not yet true #9036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 20d1e24e82b4c020a135f45e7978b3fb70e1775a
|
/hold as the issue comes only with PreFlight checks which are there beginning with v1.5 🤔 |
/retest |
I think the assessment was that this issue does happen on 1.3 and 1.4 - but it's surfaced by the preflight checks in our e2e tests. With preflight checks off this issue still occurs and reconciliation is still slower than it should be, but it doesn't block the reconciliation of MachineSets. |
/hold cancel |
120a6d9
into
kubernetes-sigs:release-1.4
/approve |
/area provider/control-plane-kubeadm |
This is an automated cherry-pick of #9032
/assign sbueringer