Commits on Aug 10, 2023

1. Fix AddAnnotations for unstructured.Unstructured …

   The previous implementation worked well for most Object implementations
   (definitely all embedding metav1.ObjectMeta) because it relies on:
   * The fact that GetAnnotations doesn't return a copy of the
   annotations but the underlying map storing them.
   * When calling set annotations, the input map is used for storage in the
     Object implementation, hence when adding entries to that map from the
     outside, it changes the content of the Object's annotations.
   This is not necessarily part of the contract specified by metav1.Object
   so we can't really guarantee all implementations will satisfy these 2
   conditions. It turns out, unstructured.Unstructured doesn't.

   

   g-gaston committed Aug 10, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for da8cb15
   • Browse repository at this point

   Copy the full SHA

   da8cb15 View commit details

   Browse the repository at this point in the history