-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🌱 Update cert-manager to v1.12.3 #9198
[release-1.5] 🌱 Update cert-manager to v1.12.3 #9198
Conversation
/lgtm |
LGTM label has been added. Git tree hash: 1ab16f6a094de1f43a8709aedb07dedeea01d7c4
|
Looks like we have to fix the broken link first:
@mjlshen Do you have some time to take a look how we can fix this link and open a PR against main to fix it? (I think we also have the issue on main) |
Looks like homebrew moved all formulas into its own subdirectories based on alphabetical order and now clusterctl lives in: https://github.com/Homebrew/homebrew-core/blob/master/Formula/c/clusterctl.rb |
I wonder why main md links job did not complain about it 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It ended up getting fixed before I got to it #9208 - thanks! |
@mjlshen looks like we need manual cherrypicks for the PR that fixes the link. Do you have some time to open those? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sbueringer done in #9238 If that looks good (first time doing something like this) I'm happy to also continue to manually cherry pick it down to release-1.4 to unblock the automated release-1.4 cherry-pick of this PR |
@mjlshen Minor detail on the PR title. Looks good thx |
Signed-off-by: Michael Shen <mishen@umich.edu>
346900f
to
617fd83
Compare
Rebased to pick up the fixed link |
/assign @killianmuldoon |
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 51bea9354eb4ce1532c3e38203fc764e2cd55132
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1c8860d
into
kubernetes-sigs:release-1.5
This is an automated cherry-pick of #9197
/assign sbueringer