-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 📖 Reword and list which deployments have to be edited for exp features. #9205
[release-1.5] 📖 Reword and list which deployments have to be edited for exp features. #9205
Conversation
/lgtm merge pending someone fixing the broken links in a separate PR :) |
LGTM label has been added. Git tree hash: e339edd7ea76206771dcb0701b8e57a4478f8882
|
/area documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the markdown link checker should only be running on files modified by this PR. Not sure why it's failing here.
The markdownlink checker issue should be resolved by https://github.com/kubernetes-sigs/cluster-api/pull/9207/files |
Re-triggered. Would be good if there is a way for the action to auto-discover the base branch. A bit annoying to update the base property when we create a release branch (in CAPI and CAPV) |
f796ee0
to
e5d48fd
Compare
Rebased onto latest release-1.5. @killianmuldoon I leave lgtm etc to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: cae23f2905188c52d2de867baee583f329f6597b
|
174ab9c
into
kubernetes-sigs:release-1.5
This is an automated cherry-pick of #9173
/assign killianmuldoon