Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] 📖 Reword and list which deployments have to be edited for exp features. #9205

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[release-1.5] 📖 Reword and list which deployments have to be edited for exp features. #9205

merged 1 commit into from
Aug 16, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #9173

/assign killianmuldoon

@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Aug 16, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 16, 2023
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

merge pending someone fixing the broken links in a separate PR :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e339edd7ea76206771dcb0701b8e57a4478f8882

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@sbueringer
Copy link
Member

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Aug 16, 2023
killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the markdown link checker should only be running on files modified by this PR. Not sure why it's failing here.

@killianmuldoon
Copy link
Contributor

The markdownlink checker issue should be resolved by https://github.com/kubernetes-sigs/cluster-api/pull/9207/files

@sbueringer
Copy link
Member

The markdownlink checker issue should be resolved by #9207 (files)

Re-triggered. Would be good if there is a way for the action to auto-discover the base branch. A bit annoying to update the base property when we create a release branch (in CAPI and CAPV)

@sbueringer sbueringer force-pushed the cherry-pick-9173-to-release-1.5 branch from f796ee0 to e5d48fd Compare August 16, 2023 11:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@sbueringer
Copy link
Member

Rebased onto latest release-1.5. @killianmuldoon I leave lgtm etc to you

killianmuldoon
killianmuldoon reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cae23f2905188c52d2de867baee583f329f6597b

@k8s-ci-robot k8s-ci-robot merged commit 174ab9c into kubernetes-sigs:release-1.5 Aug 16, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @killianmuldoon