-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🌱 Bump corefile-migration library to v1.0.21 #9309
[release-1.5] 🌱 Bump corefile-migration library to v1.0.21 #9309
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/assign @killianmuldoon @furkatgofurov7 @chrischdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area dependency
@@ -144,6 +144,9 @@ The Kubeadm Control Plane requires the Kubeadm Bootstrap Provider. | |||
| v1.3 (v1beta1) | v1.10.0 | | |||
| >= v1.3.4 (v1beta1) | v1.10.1 | | |||
| v1.4 (v1beta1) | v1.10.1 | | |||
| >= v1.4.6 (v1beta1) | v1.11.1 | | |||
| v1.5 (v1beta1) | v1.10.1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overlooked it in other PR, is this correct v1.5 <=> v1.10.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oure CoreDNS support in this table depends on the migration library we use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/coredns/corefile-migration v1.0.20
=> https://github.com/coredns/corefile-migration/releases/tag/v1.0.20
=> Corefile Migration v1.0.20 supports Corefile migrations through CoreDNS v1.10.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, will know next time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome. No problem :) Thx for asking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just assuming PR authors know what they're doing wouldn't help much on PRs 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -144,6 +144,9 @@ The Kubeadm Control Plane requires the Kubeadm Bootstrap Provider. | |||
| v1.3 (v1beta1) | v1.10.0 | | |||
| >= v1.3.4 (v1beta1) | v1.10.1 | | |||
| v1.4 (v1beta1) | v1.10.1 | | |||
| >= v1.4.6 (v1beta1) | v1.11.1 | | |||
| v1.5 (v1beta1) | v1.10.1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, will know next time :)
LGTM label has been added. Git tree hash: 859662a92f20a96aba638a7d1fa50c31a8bec146
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
97e10b0
into
kubernetes-sigs:release-1.5
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Manual cherry-pick of #9307
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #