🌱 Add MachinePool Builders

[johannesfrey]

What this PR does / why we need it:

This PR adds MachinePool Builders that can be referenced in tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Prereq for some of the MachinePool tests tracked in #5991

/area testing

_{Johannes Frey <johannes.frey@mercedes-benz.com>, Mercedes-Benz Tech Innovation GmbH (Provider Information)}

[johannesfrey]

/remove-area testing
/area machinepool

[killianmuldoon]

/lgtm

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 99275d7fe3e582d3899992e31cd823b464ed8a41

[sbueringer]

cc @chrischdi

[willie-yao]

Just one minor comment about the current diff! For blueprint_test.go, I needed to also create a InfrastructureMachinePoolTemplateBuilder type as defined here. Would you be able to include this in your PR?

main...willie-yao:cluster-api:cc-mp-unit-tests#diff-30b8ed7bcbffa0687acaccab71710d58dab625a59a40a38888069eb870b41c17R732

[johannesfrey]

Just one minor comment about the current diff! For blueprint_test.go, I needed to also create a InfrastructureMachinePoolTemplateBuilder type as defined here. Would you be able to include this in your PR?

main...willie-yao:cluster-api:cc-mp-unit-tests#diff-30b8ed7bcbffa0687acaccab71710d58dab625a59a40a38888069eb870b41c17R732

Sure, I adjusted the PR according to your changes. Thx!

In my tests I was just simply passing the ouput of InfrastructureMachineTemplate into the MachinePoolClass. Therefore, I'm a bit wondering about the reason behind naming this with MachinePool in the field name, while in the MachineDeployment it's simply named without MachineDeployment in the field name. 🤔

[sbueringer]

Lost the overview a bit. Please let me know if there are open questions (ideally open a conversation at the corresponding code location :))

[sbueringer]

@johannesfrey looks like you actually need the kind stuff: https://github.com/kubernetes-sigs/cluster-api/pull/9346/files#r1312902556

[johannesfrey]

@johannesfrey looks like you actually need the kind stuff: https://github.com/kubernetes-sigs/cluster-api/pull/9346/files#r1312902556

I went ahead to quickly 😅. Will add another commit.

[sbueringer]

@johannesfrey looks like you actually need the kind stuff: #9346 (files)

I went ahead to quickly 😅. Will add another commit.

Just please make sure you use the right Generic vs Test kind (just compare with the existing pre-existing builders)

[chrischdi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 79cd0f9b1fc9143badf0bf41e5e601053ce0bea9

[johannesfrey]

Had to do another renaming commit. Should I squash the commits before another lgtm @chrischdi ?

[sbueringer]

If you only squash the commits (i.e. without a rebase onto main) lgtm is preserved

More precisely lgtm is preserved if the git tree hash doesn't change (it is stored in a comment, e.g.: #9346 (comment), see details)

[sbueringer]

Almost there :)

[sbueringer]

Looks good. Thank you very much!!

/lgtm

approve pending squash (please just squash the commits without rebasing to main :))

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: dbae36c15261e617fb5b72109c954b33d03874a7

[sbueringer]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment