-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve Performance dashboard #9387
🌱 Improve Performance dashboard #9387
Conversation
@@ -1773,7 +1773,7 @@ | |||
}, | |||
"renameByName": { | |||
"Value": "Time until Ready", | |||
"Value #A": "Time until InfrastructureReady", | |||
"Value #A": "Time until Ready", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the Ready column in the KCP table
@@ -3835,7 +3835,7 @@ | |||
}, | |||
"renameByName": { | |||
"Value": "Time until Ready", | |||
"Value #A": "Time until BootstrapReady", | |||
"Value #A": "Time until Ready", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two are the Ready columns in KubeadmConfig tables (CP+workers)
Signed-off-by: Stefan Büringer buringerst@vmware.com
f2822e0
to
5773fc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 537daeba56ef246c09fd6d47a5a6d076ff9cae21
|
/assign @killianmuldoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area devtools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #