Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fail tests if test env version check fails #9388

Merged
merged 1 commit into from
Sep 11, 2023
Merged

🌱 Fail tests if test env version check fails #9388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/test/envtest/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ func Run(ctx context.Context, input RunInput) int {

if input.MinK8sVersion != "" {
if err := version.CheckKubernetesVersion(env.Config, input.MinK8sVersion); err != nil {
fmt.Printf("[IMPORTANT] skipping tests after failing version check: %v\n", err)
fmt.Printf("[ERROR] Cannot run tests after failing version check: %v\n", err)
if err := env.stop(); err != nil {
fmt.Println("[WARNING] Failed to stop the test environment")
}
return 0
return 1
}
}

Expand Down