🌱 Move Kubeadm API v1beta1 webhooks to separate package

[odvarkadaniel]

What this PR does / why we need it:
To work towards #9011, we need to remove the reliance on controller-runtime from the API packages.
This updates the webhooks to use the CustomDefaulter and CustomValidator pattern and moves them to match the Cluster and ClusterClass webhooks. This Is a more major lift but removes quite a bit of the code from the API package itself, making it's reliance on controller-runtime a lot smaller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Welcome @odvarkadaniel!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @odvarkadaniel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[odvarkadaniel]

/area api

[odvarkadaniel]

About to move ./bootstrap/kubeadm/api in the same fashion in this PR.

[killianmuldoon]

Thanks!

/ok-to-test

[JoelSpeed]

Changes look as expected, if we can work out the verify failures then this should be good to go, thanks for picking this up @odvarkadaniel

[odvarkadaniel]

Any idea about the verify issues?

Command make generate seems to be generating a lot of unnecessary stuff.

[killianmuldoon]

Any idea about the verify issues?
Command make generate seems to be generating a lot of unnecessary stuff.

The generate command regenerates everything. Once you've done that and committed the result - which should be relatively small as the vast majority of files won't change - you should be able to pass the verify check.

[sbueringer]

/assign @killianmuldoon @chrischdi

Would be good if one of you can also take a look. I think this is the most complicated of the webhook refactorings, so want to make sure we don't introduce bugs

[odvarkadaniel]

/assign @killianmuldoon @chrischdi

Would be good if one of you can also take a look. I think this is the most complicated of the webhook refactorings, so want to make sure we don't introduce bugs

Addressed the 2 nits you mentioned above. Also squashed all the commits.

[sbueringer]

Thank you very much!!!

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 795970522f608c22064def6b8cd46aab045483b8

[chrischdi]

Wow, that was quick

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 390e6b7f0045fc0dbd29460a9da1de8727b220e1

[k8s-ci-robot]

@odvarkadaniel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	359f92e	link	false	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sbueringer]

@odvarkadaniel Thank you very much! That was one of the trickiest :)

Thx everyone for the reviews as well!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment