🌱 [POC] [DNR] Test for adding mp to quickstart templates #9440
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
pull-cluster-api-e2e-full-main |
killianmuldoon
force-pushed
the
cc-mp-e2e-quickstart
branch
from
148366a
to
9fbe967
Compare
killianmuldoon
changed the title
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
cc-mp-e2e-quickstart
branch
from
9fbe967
to
3efb573
Compare
|
/test pull-cluster-api-e2e-full-main |
| @@ -151,7 +151,7 @@ func DumpKubeSystemPodsForCluster(ctx context.Context, input DumpKubeSystemPodsF | |||
| podList.SetKind("Pod") | |||
| var listErr error | |||
| _ = wait.PollUntilContextTimeout(ctx, retryableOperationInterval, retryableOperationTimeout, true, func(ctx context.Context) (bool, error) { | |||
| if listErr = input.Lister.List(ctx, podList, client.InNamespace(metav1.NamespaceSystem)); listErr != nil { | |||
There was a problem hiding this comment.
@sbueringer @chrischdi WDYT about making a change like this anyway? We could just go through the known CAPI namespaces, but it makes sense to me to just dump all the pods in the workload clusters.
There was a problem hiding this comment.
Yeah let's just dump all Pods. Feel free to open a separate PR. I just approved the collecting Nodes PR so you can built it on top of it.
There was a problem hiding this comment.
aggree, dumping all pods would be a great thing esepcially for self-hosted tests :-)
|
/test pull-cluster-api-e2e-full-main |
|
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon kmuldoon@vmware.com<!-- Thanks for sending a pull request! Here are some tips for you:
Testing for errors in #9393