Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add release tasks to update the GitHub actions to work with the new release #9488

Merged
merged 1 commit into from
Oct 13, 2023
Merged

📖 Add release tasks to update the GitHub actions to work with the new release #9488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/release/release-tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ From this point forward changes which should land in the release have to be cher
2. Update the [milestone applier config](https://github.com/kubernetes/test-infra/blob/0b17ef5ffd6c7aa7d8ca1372d837acfb85f7bec6/config/prow/plugins.yaml#L371) accordingly (e.g. `release-1.4: v1.4` and `main: v1.5`)
<br>Prior art: [cluster-api: update milestone applier config for v1.3](https://github.com/kubernetes/test-infra/pull/26631)

3. Update the GitHub Actions to work with the new release version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that this is covered in line ~452 under tasks for the CI lead with the creation of the other CI jobs.

Is the idea to make this part of the release lead tasks?

Copy link
Member

@furkatgofurov7 furkatgofurov7 Sep 25, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killianmuldoon I think this came up from the retrospective in the previous cycle and if I am not mistaken from you 😄 While you know better, the idea was to cover it so that we don't forget it in future releases and you had a patch (9115) that was mentioned in this PR. I was not aware it was already covered and don't see the point of making it part of RL tasks, so probably we can close it without merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea from the retro - if I remember right - was to put this in a checklist or some other easier to follow format - maybe something like the release issue, but broken down for the CI team so it's easier to follow.

I definitely missed this task when it should have been done during the last release cycle - 🤦 - and I think I probably added it to this file in the first place.

<br>Prior art: [Update actions for 1.5 and make names consistent](https://github.com/kubernetes-sigs/cluster-api/pull/9115)

#### [Continuously] Maintain the GitHub release milestone

The goal of this task is to keep an overview over the current release milestone and the implementation
Expand Down