-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🐛 Fix broken e2e test clusterclass #9504
[release-1.5] 🐛 Fix broken e2e test clusterclass #9504
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area e2e-testing
/test
@killianmuldoon: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-mink8s-release-1-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 7a9e4fa06d14767458d9ec55363cb2c51d988963
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
83e9c53
into
kubernetes-sigs:release-1.5
Issue with required not being defined was introduced in #9501. I'm not sure of the root cause, but
required
only seems to be required on older versions of Kubernetes.The test was passing
e2e-min-k8s-main
- which runs with Kubernetes v1.25 - but failinge2e-min-k8s-release-1-5
- which runs Kubernetes v1.24.Either way we should make this change in both branches after we see if it fixes the underlying issue here.