Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Give permissions for release notes tool to release team #9563

Merged
merged 1 commit into from
Nov 2, 2023
Merged

🌱 Give permissions for release notes tool to release team #9563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/release/release-team.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- [Duration of Term](#duration-of-term)
- [Specific Responsibilities](#specific-responsibilities)
- [Team Roles](#team-roles)
- [Team repo permissions](#team-repo-permissions)
- [Team Selection](#team-selection)
- [Selection Criteria](#selection-criteria)
- [Time Commitment](#time-commitment)
Expand Down Expand Up @@ -72,6 +73,14 @@ As noted above, making changes to the CAPI release cadence is out of scope for
- **Maintainer**: Responsible for tasks which require write access to the Cluster API repo including creating release tags and creating a release branch. This role must be filled by someone on the [`cluster-api-maintainers` list](https://github.com/kubernetes-sigs/cluster-api/blob/main/OWNERS_ALIASES).
*Note*: This is also documented in [Release tasks](./release-tasks.md) together with a mapping to specific tasks.

## Team repo permissions
- Release notes (`CHANGELOG` folder)
- The Release Lead has approval permissions, which allows them to merge PRs that add new release notes. This will start an automated release process through GitHub Actions: creating tags, create GitHub Release draft, etc.
- All members of the release team have `lgtm` permissions for PRs that add release notes in this folder.
- Release notes tool (`hack/tools/release` folder)
- The Release Lead has approval permissions, which allows them to merge code changes to this tool. It's not their responsibility to always review the code changes (although they can), but to make sure the right folks have `lgtm`ed the PR.
- All members of the release team have `lgtm` permissions for the release notes tool code.

## Team Selection

To start, the release team will be assembled by the release team lead based on volunteers. A call for volunteers can be made through the usual communication channels (office hours, Slack, mailing list, etc.). In the future, we may consider introducing an application process similar to the Kubernetes release team application process.
Expand Down
7 changes: 7 additions & 0 deletions hack/tools/release/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- cluster-api-release-lead

reviewers:
- cluster-api-release-team