Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] 🌱 Bump go.opentelemetry.io/* dependencies #9599

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
Trivy is failing https://github.com/kubernetes-sigs/cluster-api/actions/runs/6612918116/job/17961612952 still after we bumped golang.org/x/net to v0.17.0 in all branches. So bumping go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 and running go mod tidy outputs:

sigs.k8s.io/cluster-api/test/infrastructure/inmemory/internal/server/api imports
        k8s.io/apiserver/pkg/server imports
        k8s.io/component-base/tracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/internal: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal
sigs.k8s.io/cluster-api/test/infrastructure/inmemory/internal/server/api imports
        k8s.io/apiserver/pkg/server imports
        k8s.io/component-base/tracing imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc imports
        go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig imports
        go.opentelemetry.io/otel/exporters/otlp/internal/envconfig: module go.opentelemetry.io/otel/exporters/otlp@latest found (v0.20.1), but does not contain package go.opentelemetry.io/otel/exporters/otlp/internal/envconfig

so I had to bump some other dependencies in go.opentelemetry.io/otel/* package to get pass the trivy scan workflow. Tested it in my fork and passed: https://github.com/furkatgofurov7/cluster-api/actions/runs/6613251793/job/17965058387. Hopefully it should pass after this change in our GH workflow

/area dependency

@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2023
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Member Author

/cc @killianmuldoon @sbueringer

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for additional coverage (not sure how we use the grpc)

/test pull-cluster-api-e2e-full-release-1-5

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cd70dc0aeb147034526ac3c8cc67dbf0abc91c7b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@@ -7,7 +7,7 @@ replace sigs.k8s.io/cluster-api => ../../
replace sigs.k8s.io/cluster-api/test => ../../test

require (
cloud.google.com/go/storage v1.29.0
cloud.google.com/go/storage v1.30.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these and below deps were not bumped intentionally but automatically while running go mod tidy in the hack/tools folder

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furkatgofurov7
Copy link
Member Author

@sbueringer e2e full is green, can we unhold it?

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b7c0f0 into kubernetes-sigs:release-1.5 Oct 23, 2023
19 checks passed
@furkatgofurov7 furkatgofurov7 deleted the bump-opentelemetry-bumps branch October 23, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants