-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.5] 🌱 Bump go.opentelemetry.io/* dependencies #9599
[release-1.5] 🌱 Bump go.opentelemetry.io/* dependencies #9599
Conversation
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
aca6b59
to
8a50859
Compare
/lgtm /hold /test pull-cluster-api-e2e-full-release-1-5 |
LGTM label has been added. Git tree hash: cd70dc0aeb147034526ac3c8cc67dbf0abc91c7b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -7,7 +7,7 @@ replace sigs.k8s.io/cluster-api => ../../ | |||
replace sigs.k8s.io/cluster-api/test => ../../test | |||
|
|||
require ( | |||
cloud.google.com/go/storage v1.29.0 | |||
cloud.google.com/go/storage v1.30.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: these and below deps were not bumped intentionally but automatically while running go mod tidy
in the hack/tools folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sbueringer e2e full is green, can we unhold it? |
/hold cancel |
What this PR does / why we need it:
Trivy is failing https://github.com/kubernetes-sigs/cluster-api/actions/runs/6612918116/job/17961612952 still after we bumped golang.org/x/net to v0.17.0 in all branches. So bumping
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
to v0.44.0 and running go mod tidy outputs:so I had to bump some other dependencies in go.opentelemetry.io/otel/* package to get pass the trivy scan workflow. Tested it in my fork and passed: https://github.com/furkatgofurov7/cluster-api/actions/runs/6613251793/job/17965058387. Hopefully it should pass after this change in our GH workflow
/area dependency