🌱 Improve output of exec.KubectlApply

[sbueringer]

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/assign @fabriziopandini @chrischdi

[chrischdi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: fc2f0d8ad5ee20aaf45909951c100806a4421f72

[sbueringer]

/assign @fabriziopandini

[vincepri]

While we're here, should we move these to be fmt.Errorf instead?

[sbueringer]

Not sure if I got your question correctly.

I think as of today github.com/pkg/errors is still the standard in CAPI that we use everywhere to create and wrap errors. Are you asking to use the Go SDK funcs instead? If yes, I would defer that to a separate issue / PR / discussion around if we want to migrate away from pkg/errors.

Related: Previously closed issue around migrating away from pkg/errors: #6688

[sbueringer]

Merged this PR for now as we would like to use it to debug e2e tests. Happy to continue the conversation and follow-up accordingly

[vincepri]

The packages are compatibile with each other, especially the wrap/unwrap; we could just use those going forward

[sbueringer]

Isn't there a difference in the amount of information they store in the errors? (pkg/errors stores the entire stacktrace which then gets logged if JSON logging is used)

(we should probably move this discussion to an issue, so others see it as well)

[fabriziopandini]

/lgtm
/approve

+1 to have the discussion on fmt.error on a separated thread

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cherry-pick release-1.6

(we also want this on other branches to ease debugging there)

[sbueringer]

/cherry-pick release-1.5

[sbueringer]

/cherry-pick release-1.4

[k8s-infra-cherrypick-robot]

@sbueringer: #9737 failed to apply on top of branch "release-1.5":

Applying: Improve output of exec.KubectlApply
Using index info to reconstruct a base tree...
M	cmd/clusterctl/cmd/topology_plan.go
M	test/framework/cluster_proxy.go
M	test/framework/clusterctl/client.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/clusterctl/client.go
Auto-merging test/framework/cluster_proxy.go
Auto-merging cmd/clusterctl/cmd/topology_plan.go
CONFLICT (content): Merge conflict in cmd/clusterctl/cmd/topology_plan.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Improve output of exec.KubectlApply
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #9737 failed to apply on top of branch "release-1.4":

Applying: Improve output of exec.KubectlApply
Using index info to reconstruct a base tree...
M	cmd/clusterctl/cmd/topology_plan.go
M	test/framework/cluster_proxy.go
M	test/framework/clusterctl/client.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/clusterctl/client.go
Auto-merging test/framework/cluster_proxy.go
Auto-merging cmd/clusterctl/cmd/topology_plan.go
CONFLICT (content): Merge conflict in cmd/clusterctl/cmd/topology_plan.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Improve output of exec.KubectlApply
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #9761

In response to this:

/cherry-pick release-1.6

(we also want this on other branches to ease debugging there)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.