-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improve output of exec.KubectlApply #9737
🌱 Improve output of exec.KubectlApply #9737
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
f817db2
to
adce020
Compare
/assign @fabriziopandini @chrischdi |
/lgtm |
LGTM label has been added. Git tree hash: fc2f0d8ad5ee20aaf45909951c100806a4421f72
|
/assign @fabriziopandini |
return errors.Wrapf(err, "failed to read input file %q", f) | ||
return pkgerrors.Wrapf(err, "failed to read input file %q", f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're here, should we move these to be fmt.Errorf instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I got your question correctly.
I think as of today github.com/pkg/errors is still the standard in CAPI that we use everywhere to create and wrap errors. Are you asking to use the Go SDK funcs instead? If yes, I would defer that to a separate issue / PR / discussion around if we want to migrate away from pkg/errors.
Related: Previously closed issue around migrating away from pkg/errors: #6688
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged this PR for now as we would like to use it to debug e2e tests. Happy to continue the conversation and follow-up accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packages are compatibile with each other, especially the wrap/unwrap; we could just use those going forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a difference in the amount of information they store in the errors? (pkg/errors stores the entire stacktrace which then gets logged if JSON logging is used)
(we should probably move this discussion to an issue, so others see it as well)
/lgtm +1 to have the discussion on fmt.error on a separated thread |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.6 (we also want this on other branches to ease debugging there) |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 |
@sbueringer: #9737 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #9737 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #9761 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #