Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update clusterctl version to v1.6.x in quick start #9801

Merged
merged 1 commit into from
Dec 5, 2023
Merged

📖 Update clusterctl version to v1.6.x in quick start #9801

merged 1 commit into from
Dec 5, 2023

Conversation

g-gaston
Copy link
Contributor

@g-gaston g-gaston commented Dec 4, 2023

/area documentation
/cherry-pick release-1.6

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2023
@furkatgofurov7
Copy link
Member

/retitle 📖 Update clusterctl version to v1.6.x in quick start
/hold
until we have a v1.6.0 tag.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@k8s-ci-robot k8s-ci-robot changed the title 📖 Update clusterctl version to v1.5.x in quick start 📖 Update clusterctl version to v1.6.x in quick start Dec 4, 2023
furkatgofurov7
furkatgofurov7 reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @CecileRobertMichon @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 131f19739c4622f5266458a2d3186dd6bbdecdbd

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@g-gaston g-gaston force-pushed the update-clusterctl-quicktart-links-1.6 branch from ffbc4c0 to a612621 Compare December 4, 2023 17:36
@g-gaston
Copy link
Contributor Author

g-gaston commented Dec 4, 2023

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot
Copy link

@g-gaston: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furkatgofurov7 furkatgofurov7 mentioned this pull request Dec 5, 2023
Closed
29 tasks
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0512f37 into kubernetes-sigs:main Dec 5, 2023
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 5, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 5, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@g-gaston: new pull request created: #9816

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@g-gaston @furkatgofurov7 @k8s-ci-robot @CecileRobertMichon @k8s-infra-cherrypick-robot @sbueringer