🌱 Release v1.6.0 #9807
🌱 Release v1.6.0 #9807
Conversation
k8s-ci-robot
added
area/release
k8s-ci-robot
added
the
size/L
| - Metrics: Hack/observability: add capi_machine_status_certificatesexpirydate metric (#9084) | ||
| - Metrics: Hack: bump kube-state-metrics and prometheus charts (#9352) | ||
| - Release: Add additional blocks to release note generation (#9247) | ||
| - Release: Add adilGhaffarDev to release-team owner alias (#9718) |
There was a problem hiding this comment.
Side note: I wonder if need a separate category for release, testing, etc. since there are so many "other" changes
k8s-ci-robot
added
do-not-merge/hold
| - Dependency: Bump github.com/fatih/color from 1.15.0 to 1.16.0 (#9681) | ||
| - Dependency: Bump github.com/go-logr/logr from 1.2.4 to 1.3.0 (#9644) | ||
| - Dependency: Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (#9562) | ||
| - Dependency: Bump github.com/onsi/ginkgo/v2 from 2.13.0 to 2.13.1 (#9716) |
There was a problem hiding this comment.
Q: Could it be that we only have one changelog entry for dependencies that have been bumped multiple times?
E.g. ginkgo in release-1.5 was not v2.13.0 as it seems here in the changelog
There was a problem hiding this comment.
yes, we do remove "duplicated" entries for the same module
It's documented in the release process
We can discuss a process change, I don't mind having multiple entries for the same dependency
There was a problem hiding this comment.
Definitely let's not delay this release for it.
The main thing I don't like is that it now looks like we upgraded only from 2.13.0 to 2.13.1 (even though the source versions are totally different).
In the past I merged entries by modifying the source / target version to capture all bumps + add all the PRs.
As nobody actually cares about the bump PRs I think the ideal solution would be to be able to just generate the list of bumped dependencies and drop the individual PRs entirely from the release notes. This would give us also a more accurate and complete list of bumps (compare with what k/k is doing).
In any case, let's definitely keep it as is for now, but it might be worth a follow-up issue.
g-gaston
force-pushed
the
release-1.6.0
branch
from
9b753af
to
29dce57
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 988fe67252c26f9468f9ea399e779eefeb33d48b
|
|
Thank you!! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
/area release