-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 clusterctl: validate no objects exist from CRDs before deleting them #9808
🐛 clusterctl: validate no objects exist from CRDs before deleting them #9808
Conversation
443266f
to
3b05fbb
Compare
4e3e12d
to
3455df0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
3455df0
to
0585527
Compare
/retest |
0585527
to
b8f1cc0
Compare
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thx! /lgtm |
LGTM label has been added. Git tree hash: a733c0403a85c6734eacbb95652ec2efef2fd75a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If possible I would like to cherry-pick this into release-1.6 and release-1.5. I think it's currently not intended that @CecileRobertMichon @enxebre @vincepri @fabriziopandini Fine for you if we cherry-pick? |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
@sbueringer: #9808 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #9834 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds a safeguard when
clusterctl delete --include-crd
is executed to not do anything if there are still Custom Resources for a CRD.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9732
/area clusterctl