🐛 test: wait for topology to get rolled out before continuing with scaling checks

[chrischdi]

What this PR does / why we need it:

Fixes a race condition in the test function ScaleAndWaitMachineDeploymentTopology, when:

• The Cluster object gets patched:

  • cluster-api/test/framework/machinedeployment_helpers.go

    Line 536 in 3711210

    return patchHelper.Patch(ctx, input.Cluster)

• And the Machinedeployment gets retrieced

  • cluster-api/test/framework/machinedeployment_helpers.go

    Line 542 in 3711210

    return input.ClusterProxy.GetClient().List(ctx, deploymentList,

It could be the case that the topology controller did not yet update the MachineDeployment with the new number of replicas. But we use .spec.replicas from the machinedeployment.

This fixes the race condition by using the replicas from the provided input instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area testing

[chrischdi]

/retest

[sbueringer]

Thx, nice catch!!

/lgtm
/approve

/test pull-cluster-api-e2e-full-main

cc @kubernetes-sigs/cluster-api-release-team

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 0f1cd2bb7a22c759e709195ea9dba112cf26dd4a

[chrischdi]

Potentially a good cherry-pick. Maybe we hit this for some flakes. But we should see that when a flake only happens on <= v1.6 :-) Would help to get a test stable for CAPV when at least cherry-picked into v1.6.

[fabriziopandini]

good catch
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Fine to cherry-pick

[sbueringer]

/override pull-cluster-api-e2e-full-main

Test is green. No idea what tide is doing

[k8s-ci-robot]

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-full-main

In response to this:

/override pull-cluster-api-e2e-full-main

Test is green. No idea what tide is doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[furkatgofurov7]

/lgtm

Thanks @chrischdi!

[sbueringer]

/retest

[chrischdi]

Very weird. Pushed again without changes.

[chrischdi]

/retitle 🐛 test: wait for topology to get rolled out before continuing with scaling checks

[sbueringer]

/cherry-pick release-1.6

[sbueringer]

cherry-pick release-1.5

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #9827

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/cherry-pick release-1.5

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #9828

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.