🌱 Add proxmox to provider list #9829
Conversation
k8s-ci-robot
added
area/documentation
k8s-ci-robot
added
the
size/XS
|
@mcbenjemaa WDYT about also already fixing the "tabs" in the quickstart doc? (as discussed in Slack) |
| @@ -44,6 +44,7 @@ updated info about which API version they are supporting. | |||
| - [Oracle Cloud Infrastructure (OCI)](https://github.com/oracle/cluster-api-provider-oci) | |||
| - [OpenStack](https://github.com/kubernetes-sigs/cluster-api-provider-openstack) | |||
| - [Outscale](https://github.com/outscale/cluster-api-provider-outscale) | |||
| - [Proxmox](https://github.com/ionos-cloud/cluster-api-provider-proxmox) | |||
There was a problem hiding this comment.
Thanks for adding this! Great to see Cluster API on Proxmox :)
k8s-ci-robot
added
size/L
mcbenjemaa
changed the title
|
The tabs are now fixed. |
| @@ -406,7 +406,12 @@ cite.literate-source > a::before { | |||
| .tabset > input:nth-child(33):checked ~ .tab-panels > .tab-panel:nth-child(17), | |||
| .tabset > input:nth-child(35):checked ~ .tab-panels > .tab-panel:nth-child(18), | |||
| .tabset > input:nth-child(37):checked ~ .tab-panels > .tab-panel:nth-child(19), | |||
There was a problem hiding this comment.
Thx for debugging this.
Context for others. Because of this css our tabs are limited to 25 (before this PR 20, Proxmox is #21)
|
Looks good now > https://deploy-preview-9829--kubernetes-sigs-cluster-api.netlify.app/user/quick-start /lgtm /cherry-pick release-1.6 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: decc5f105d309bdbe07325030d8c36a4109da0f6
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #9830 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Since we added proxmox to default clusterctl, we also need to reference it in the docs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area documentation