Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 add members of 1.7 release #9831

Merged
merged 1 commit into from
Dec 11, 2023
Merged

📖 add members of 1.7 release #9831

merged 1 commit into from
Dec 11, 2023

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Dec 7, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of: 9800

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Dec 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2023
@cahillsf cahillsf mentioned this pull request Dec 7, 2023
Closed
30 tasks
@cahillsf cahillsf changed the title add members 📖 add members of 1.7 release Dec 7, 2023
@cahillsf
Copy link
Member Author

cahillsf commented Dec 7, 2023

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
@cahillsf cahillsf marked this pull request as ready for review December 10, 2023 17:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2023
@adilGhaffarDev
Copy link
Contributor

LGTM from my side

@sbueringer
Copy link
Member

sbueringer commented Dec 11, 2023 •
edited

/lgtm
/approve

Looks good at a first glance. I did not verify all the IDs

/hold
in case you want others to review before merge. Feel free to just merge it

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e4d84798312e0156a80c068518ae8d596c8fa41

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@willie-yao
Copy link
Contributor

/lgtm

@cahillsf
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2575fa5 into kubernetes-sigs:main Dec 11, 2023
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

@hackeramitkumar hackeramitkumar Awaiting requested review from hackeramitkumar

@nprokopic nprokopic Awaiting requested review from nprokopic

Assignees

@sbueringer sbueringer

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cahillsf @k8s-ci-robot @adilGhaffarDev @sbueringer @willie-yao