-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱Remove k8s.io/utils/pointer from repository #9836
🌱Remove k8s.io/utils/pointer from repository #9836
Conversation
e2885c6
to
6e353af
Compare
/area testing |
@troy0820: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@troy0820 Can you please rebase the PR? |
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
6e353af
to
b30d12b
Compare
Thank you very much!! Couldn't find anything :) /lgtm |
LGTM label has been added. Git tree hash: d46f6c0f23242589111b566e958bf0e2a47c0220
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
There was a PR that removed most of these references but left them in the test cases. This PR removes the left over references and removes them from the
_test.go
files/kind cleanup
k8s.io/utils/pointer
from repositoryk8s.io/utils/ptr
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes the rest of this PR #7396
Notes for reviewers:
Sorry this PR is so large but most of this was replacing
pointer
->ptr