Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update links in release tasks docs #9856

Merged

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Dec 12, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Relates to #9800

follow up from last v1.6 release cut

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2023
@cahillsf
Copy link
Member Author

👋 @furkatgofurov7 did i capture all the links we wanted to update?

@cahillsf
Copy link
Member Author

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing and removed do-not-merge/needs-area PR is missing an area label labels Dec 12, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cahillsf I would update all references in the doc for "Prior art" mentions with newer PR references and adapt the doc to be based off of the latest 1.6 release, i.e replacing all mentions of release-1.4 with release-1.6 and changes needed accordingly

docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2023
@cahillsf cahillsf marked this pull request as ready for review December 15, 2023 14:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending one nit!

docs/release/release-tasks.md Outdated Show resolved Hide resolved
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tasks from comms team seem to be still needing an update (first 3) and some minor nits, overall looks good so far

docs/release/release-tasks.md Outdated Show resolved Hide resolved
docs/release/release-tasks.md Outdated Show resolved Hide resolved
@cahillsf
Copy link
Member Author

cahillsf commented Dec 19, 2023

Few tasks from comms team seem to be still needing an update (first 3) and some minor nits, overall looks good so far

thanks @furkatgofurov7 , i pushed an update to the first two. this one is a bit interesting because it doesn't look like they've been done for the v1.6 cycle.

it's strange though because this link for 1.5 works (https://release-1-5.cluster-api.sigs.k8s.io/) even though there does not appear to be a cname entry for it in the file referenced for prior art: https://github.com/ykakarap/k8s.io/blob/5a3c7bfb63ca564a0912ee346a1585b02530b0d0/dns/zone-configs/k8s.io._0_base.yaml#L398-L400

cc @willie-yao

any ideas as to why 1.5 link is served without a CNAME entry? how can we move forward with having 1.6 link serve correctly?

@willie-yao
Copy link
Contributor

any ideas as to why 1.5 link is served without a CNAME entry? how can we move forward with having 1.6 link serve correctly?

Hmm that is quite weird. I didn't work on this task for the v1.6 cycle but I'll take a look and work on a fix!

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c35a1c551b862cc695b7364485ee347bb8d5e12

@furkatgofurov7
Copy link
Member

this one is a bit interesting because it doesn't look like they've been done for the v1.6 cycle.

why, we did it in: https://github.com/kubernetes-sigs/cluster-api/pull/9767/files & kubernetes/k8s.io#6114. Generally, you can also take a look at #9094 for all the references (PRs) of the tasks

@SubhasmitaSw
Copy link
Contributor

/lgtm

@cahillsf
Copy link
Member Author

cahillsf commented Dec 20, 2023

ah thanks @furkatgofurov7, smh ended up looking at a fork:

https://github.com/ykakarap/k8s.io/blob/5a3c7bfb63ca564a0912ee346a1585b02530b0d0/dns/zone-configs/k8s.io._0_base.yaml#L398-L400

just to confirm:

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
@cahillsf
Copy link
Member Author

cool thanks for all the input here -- @willie-yao @furkatgofurov7 mind giving another lgtm when you have a chance? i think all the feedback has been addressed

@willie-yao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e29d3c76ddfe8db92ed21bb9b46cfe1124adfde3

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cahillsf, lgtm pending squash from my side

@cahillsf
Copy link
Member Author

cahillsf commented Dec 24, 2023

merging after squashing per LGTMs above

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahillsf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7804b0c into kubernetes-sigs:main Dec 24, 2023
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants