-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update links in release tasks docs #9856
📖 update links in release tasks docs #9856
Conversation
Skipping CI for Draft Pull Request. |
👋 @furkatgofurov7 did i capture all the links we wanted to update? |
1edbd09
to
98730c5
Compare
/area release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cahillsf I would update all references in the doc for "Prior art" mentions with newer PR references and adapt the doc to be based off of the latest 1.6 release, i.e replacing all mentions of release-1.4
with release-1.6
and changes needed accordingly
c434897
to
ec270ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending one nit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few tasks from comms team seem to be still needing an update (first 3) and some minor nits, overall looks good so far
thanks @furkatgofurov7 , i pushed an update to the first two. this one is a bit interesting because it doesn't look like they've been done for the v1.6 cycle. it's strange though because this link for 1.5 works (https://release-1-5.cluster-api.sigs.k8s.io/) even though there does not appear to be a cname entry for it in the file referenced for prior art: https://github.com/ykakarap/k8s.io/blob/5a3c7bfb63ca564a0912ee346a1585b02530b0d0/dns/zone-configs/k8s.io._0_base.yaml#L398-L400 cc @willie-yao any ideas as to why 1.5 link is served without a CNAME entry? how can we move forward with having 1.6 link serve correctly? |
Hmm that is quite weird. I didn't work on this task for the v1.6 cycle but I'll take a look and work on a fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 3c35a1c551b862cc695b7364485ee347bb8d5e12
|
why, we did it in: https://github.com/kubernetes-sigs/cluster-api/pull/9767/files & kubernetes/k8s.io#6114. Generally, you can also take a look at #9094 for all the references (PRs) of the tasks |
/lgtm |
ah thanks @furkatgofurov7, smh ended up looking at a fork: just to confirm:
|
cool thanks for all the input here -- @willie-yao @furkatgofurov7 mind giving another lgtm when you have a chance? i think all the feedback has been addressed |
/lgtm |
LGTM label has been added. Git tree hash: e29d3c76ddfe8db92ed21bb9b46cfe1124adfde3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cahillsf, lgtm pending squash from my side
68d2316
to
3984f26
Compare
merging after squashing per LGTMs above /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahillsf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Relates to #9800
follow up from last v1.6 release cut