✨ v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9872

chrischdi · 2023-12-13T11:18:38Z

What this PR does / why we need it:

Modify quickstart and CAPD to use the new Kubernetes release:

Bump the Kubernetes version in:
- test/*: search for occurrences of the previous Kubernetes version
- Tiltfile
Ensure the latest available kind version is used (including the latest images for this kind release)
- Add new images in the kind mapper.go.
  - See the kind releases page for the list of released images.
- Set new default image for the test framework
Verify the quickstart manually
Bump InitWithKubernetesVersion and WorkloadKubernetesVersion in clusterctl_upgrade_test.go
- Note: Only bump for Cluster API versions that will support the new Kubernetes release.
Prior art: ✨ v1.28: Prepare quickstart, capd and tests for the new release including kind bump #9160

TODO's:

Wait for dependend PR to merge
- 🌱 Prep main branch for v1.7 development #9799
Rebase after above got merged
Wait for kindest/node image to be released for v1.29.0
Fix open TODO(chrischdi)'s to set proper SHA's to the new image
verify the quickstart manually

Follow-up

manually cherry-pick this PR after merge to release-1.6
- prior art: [release-1.5] ✨ v1.28: Prepare quickstart, capd and tests for the new release includi… #9225

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #9578

/area testing

k8s-ci-robot · 2023-12-13T11:18:42Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

chrischdi · 2023-12-15T11:08:52Z

/test help

k8s-ci-robot · 2023-12-15T11:08:55Z

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-workload-upgrade-1-28-latest-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-scale-main-experimental

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-12-15T11:09:08Z

/test pull-cluster-api-e2e-full-main

chrischdi · 2023-12-15T12:17:44Z

/assign @sbueringer

test/e2e/autoscaler_test.go

test/e2e/clusterctl_upgrade_test.go

chrischdi · 2023-12-15T12:52:49Z

/test pull-cluster-api-e2e-full-main

test/e2e/config/docker.yaml

chrischdi · 2023-12-15T13:25:06Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2023-12-15T13:31:02Z

/lgtm
/approve

/hold

Feel free to merge once CI is green and the commits are squashed one way or another :)

(Please track the follow-ups of bumping the remaining places to 1.29 somewhere on the issue)

k8s-ci-robot · 2023-12-15T13:31:08Z

LGTM label has been added.

Git tree hash: e7dc20d64186e1eaed610f099b559e68704fac92

k8s-ci-robot · 2023-12-15T13:31:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sbueringer · 2023-12-18T15:49:07Z

/test pull-cluster-api-e2e-full-main

…ng kind bump

chrischdi · 2023-12-18T17:23:08Z

/lgtm

Just squashed

k8s-ci-robot · 2023-12-18T17:23:09Z

@chrischdi: you cannot LGTM your own PR.

In response to this:

/lgtm

Just squashed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-12-18T17:24:36Z

Final verification after rebase:

/test pull-cluster-api-e2e-full-main

chrischdi · 2023-12-18T19:22:07Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2023-12-18T21:33:33Z

/lgtm

k8s-ci-robot · 2023-12-18T21:33:39Z

LGTM label has been added.

Git tree hash: 298656b2aa87536adc4923fda0efea03ecef921b

sbueringer · 2023-12-18T21:33:45Z

/test pull-cluster-api-e2e-full-main

fabriziopandini

lgtm pending two questions

fabriziopandini · 2023-12-18T21:49:12Z

test/e2e/clusterctl_upgrade_test.go

@@ -144,7 +144,7 @@ var _ = Describe("When testing clusterctl upgrades (v1.6=>current)", func() {
 			InitWithBinary:            fmt.Sprintf(clusterctlDownloadURL, stableRelease),
 			InitWithProvidersContract: "v1beta1",
 			//  Note: Both InitWithKubernetesVersion and WorkloadKubernetesVersion should be the highest mgmt cluster version supported by the source Cluster API version.
-			InitWithKubernetesVersion: "v1.28.0",
+			InitWithKubernetesVersion: "v1.29.0",


q: should we change also WorkloadKubernetesVersion? (same below)

We have to wait until 1.6.1. before that it won't work as 1.6 doesn't have a mapping for the 1.29 image

(xref last task in #9578 (comment))

fabriziopandini · 2023-12-18T21:50:48Z

test/e2e/config/docker.yaml

-  COREDNS_VERSION_UPGRADE_TO: "v1.10.1"
+  KUBERNETES_VERSION_MANAGEMENT: "v1.29.0"
+  KUBERNETES_VERSION: "v1.29.0"
+  KUBERNETES_VERSION_UPGRADE_FROM: "v1.28.0"


Q: should be use v1.28.4 instead? (it is ok to do this as a follow up)

There seems to be no kind image for it

sbueringer · 2023-12-19T05:34:30Z

/test pull-cluster-api-e2e-full-main

sbueringer · 2023-12-19T08:12:00Z

/hold cancel

k8s-ci-robot requested review from elmiko and jackfrancis December 13, 2023 11:18

This was referenced Dec 13, 2023

CAPI: bump jobs for v1.29 kubernetes/test-infra#31441

Merged

Tasks to bump to Kubernetes v1.29 #9578

Closed

chrischdi force-pushed the pr-main-1-29 branch 2 times, most recently from cbdb8cf to 0c5d8ca Compare December 15, 2023 11:08

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 15, 2023

chrischdi marked this pull request as ready for review December 15, 2023 11:08

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2023

k8s-ci-robot requested a review from fabriziopandini December 15, 2023 11:08

k8s-ci-robot assigned sbueringer Dec 15, 2023

sbueringer reviewed Dec 15, 2023

View reviewed changes

test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved

test/e2e/clusterctl_upgrade_test.go Outdated Show resolved Hide resolved

sbueringer reviewed Dec 15, 2023

View reviewed changes

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 15, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023

This was referenced Dec 18, 2023

✨ [release-1.6] v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9890

Merged

🐛 capd: fix ignition to also set the kube-proxy configuration to skip setting sysctls #9894

Merged

v1.29: Prepare quickstart, capd and tests for the new release includi…

d23bb93

…ng kind bump

chrischdi force-pushed the pr-main-1-29 branch from 2539650 to d23bb93 Compare December 18, 2023 17:17

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023

k8s-ci-robot requested a review from sbueringer December 18, 2023 17:17

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023

fabriziopandini reviewed Dec 18, 2023

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2023

k8s-ci-robot merged commit cd844c3 into kubernetes-sigs:main Dec 19, 2023
21 checks passed

k8s-ci-robot added this to the v1.7 milestone Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9872

✨ v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9872

chrischdi commented Dec 13, 2023 •

edited

Loading

k8s-ci-robot commented Dec 13, 2023

chrischdi commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

sbueringer commented Dec 15, 2023 •

edited

Loading

k8s-ci-robot commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

sbueringer commented Dec 18, 2023

chrischdi commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

chrischdi commented Dec 18, 2023

chrischdi commented Dec 18, 2023

sbueringer commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

sbueringer commented Dec 18, 2023

fabriziopandini left a comment

fabriziopandini Dec 18, 2023

sbueringer Dec 19, 2023

sbueringer Dec 19, 2023

fabriziopandini Dec 18, 2023

sbueringer Dec 19, 2023

sbueringer commented Dec 19, 2023

sbueringer commented Dec 19, 2023

✨ v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9872

✨ v1.29: Prepare quickstart, capd and tests for the new release including kind bump #9872

Conversation

chrischdi commented Dec 13, 2023 • edited Loading

k8s-ci-robot commented Dec 13, 2023

chrischdi commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

chrischdi commented Dec 15, 2023

sbueringer commented Dec 15, 2023 • edited Loading

k8s-ci-robot commented Dec 15, 2023

k8s-ci-robot commented Dec 15, 2023

sbueringer commented Dec 18, 2023

chrischdi commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

chrischdi commented Dec 18, 2023

chrischdi commented Dec 18, 2023

sbueringer commented Dec 18, 2023

k8s-ci-robot commented Dec 18, 2023

sbueringer commented Dec 18, 2023

fabriziopandini left a comment

Choose a reason for hiding this comment

fabriziopandini Dec 18, 2023

Choose a reason for hiding this comment

sbueringer Dec 19, 2023

Choose a reason for hiding this comment

sbueringer Dec 19, 2023

Choose a reason for hiding this comment

fabriziopandini Dec 18, 2023

Choose a reason for hiding this comment

sbueringer Dec 19, 2023

Choose a reason for hiding this comment

sbueringer commented Dec 19, 2023

sbueringer commented Dec 19, 2023

chrischdi commented Dec 13, 2023 •

edited

Loading

sbueringer commented Dec 15, 2023 •

edited

Loading