馃悰 test: Fix finalizers test to not only rely on namespaced name #9891
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/retitle 馃悰 test: Fix finalizers test to not only rely on namespaced name |
k8s-ci-robot
changed the title
|
/test help |
|
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main |
chrischdi
force-pushed
the
pr-fix-finalizers-e2e-test
branch
from
9ae9c1c
to
9cd5f27
Compare
|
/test pull-cluster-api-e2e-full-main |
sbueringer
added
area/e2e-testing
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9ae370b8089bf93f405930cdfc362838f949f670
|
|
Failed because of the other flake otherwise green /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/override pull-cluster-api-e2e-full-main |
|
@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-full-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.6 |
|
@sbueringer: new pull request created: #10004 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
#9833 introduced that objects like e.g. machine and dockermachine use the same name.
The finalizers test relied on the name for indexing objects which is not possible anymore after the above change.
This fix adds the kind to the index used in the test to not mix up types.
Fixes this flakes
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area testing