馃悰 test/e2e: Calculate correct worker count in clusterctl upgrade test #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-cluster-api-e2e-full-main |
sbueringer
changed the title
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-fix-clusterctl-upgrade
branch
from
84ceb9b
to
3f78f82
Compare
|
/test pull-cluster-api-e2e-full-main |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0447c4bd308b520e96999d1993b2d33225f584f5
|
|
Merging given lgtm above /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan B眉ringer buringerst@vmware.com
What this PR does / why we need it:
Since #9799 we are testing the upgrade from v1.6. In v1.6 we introduced support for MachinePools in ClusterClass.
Before this PR we assumed that the number of expected machines is controlPlaneMachineCount+workerMachineCount
With this PR we are now taking a closer look at Cluster / MachineDeployment / MachinePool objects to calculate the actual expected count.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9886