Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Small improvements to the inmemory api server #9935

Merged
merged 1 commit into from
Jan 8, 2024
Merged

🌱 Small improvements to the inmemory api server #9935

merged 1 commit into from
Jan 8, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Two small improvements to the inmemory api server:

  • Add API resource definitions for supporting also Service and Endpoints API objects (and sort alphabetically API resource definitions)
  • Properly handle returning well-known API errors

/area testing

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 28, 2023
chrischdi
chrischdi reviewed Dec 28, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9a6e6ae762ccce643fcbdf36beb3e20c8e5bc6e

@fabriziopandini fabriziopandini force-pushed the small-improvements-to-inmemory-api-server branch from d6dd889 to bfacbbd Compare January 8, 2024 13:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@sbueringer
Copy link
Member

Up to you, what you want to do with: #9935 (comment)

/lgtm
/approve

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b0ec3e529f788d476365442beec642d53a74d4f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@fabriziopandini fabriziopandini force-pushed the small-improvements-to-inmemory-api-server branch from bfacbbd to 3009d09 Compare January 8, 2024 17:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3070bd30d38d4acfa6e820e5a3894e72166ae8cd

@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 17a5a74 into kubernetes-sigs:main Jan 8, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 8, 2024
@fabriziopandini fabriziopandini deleted the small-improvements-to-inmemory-api-server branch January 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@chrischdi chrischdi Awaiting requested review from chrischdi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabriziopandini @k8s-ci-robot @sbueringer @chrischdi