🌱 test: add dynamic finalizer assertions for e2e framework

[adityabhatia]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #9969

/area testing

[k8s-ci-robot]

Hi @adityabhatia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

[sbueringer]

@adityabhatia There seems to be something wrong with the commit. The diff looks correct in GitHub but based on the commit title and locally it is a merged commit.

[sbueringer]

Looks good.

Just two nits.

Let's hold this PR until we fixed the finalizer test on main. Just to not add another change on top of the current flake :)

[sbueringer]

@adityabhatia Happy to merge this PR now that we reverted the other PR that broke CI (+/- addressing nits / rebase)., to unblock the work in CAPV.

[adityabhatia]

@adityabhatia Happy to merge this PR now that we reverted the other PR that broke CI (+/- addressing nits / rebase)., to unblock the work in CAPV.

Rebased on main (post revert) and ready for review :)

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: b9346724cb943c4d5c7f77faddbc87ddcee6756f

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@sbueringer: #9970 failed to apply on top of branch "release-1.6":

Applying: test: add dynamic finalizer assertions for e2e framework
Using index info to reconstruct a base tree...
M	test/e2e/quick_start_test.go
M	test/framework/finalizers_helpers.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/finalizers_helpers.go
CONFLICT (content): Merge conflict in test/framework/finalizers_helpers.go
Auto-merging test/e2e/quick_start_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: add dynamic finalizer assertions for e2e framework
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

@adityabhatia Can you open a cherry-pick PR please?