Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex update: added start anchor and trailing "/" to prevent false positives #21

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

aroradaman
Copy link
Member

@aroradaman aroradaman commented Mar 1, 2023

added start anchor and / to the regex expression

This will cover k8s.gcr.io.[mirror].io registries.

possible solves: https://kubernetes.slack.com/archives/CCK68P2Q2/p1677522163886019?thread_ts=1677416006.142059&cid=CCK68P2Q2

@aroradaman aroradaman requested a review from dims March 1, 2023 09:14
@aroradaman aroradaman changed the title regex update: added start anchor and trailing "\" to prevent false positives regex update: added start anchor and trailing "/" to prevent false positives Mar 1, 2023
@dims dims merged commit 572f1f5 into kubernetes-sigs:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants