Don't use pointer for sync.Mutex

kubernetes-sigs · Apr 9, 2019 · 29b471a · 29b471a
1 parent cf499c8
commit 29b471a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/log/deleg.go b/pkg/log/deleg.go
@@ -27,7 +27,7 @@ import (
 type loggerPromise struct {
 	logger        *DelegatingLogger
 	childPromises []*loggerPromise
-	promisesLock  *sync.Mutex
+	promisesLock  sync.Mutex
 
 	name *string
 	tags []interface{}
@@ -38,7 +38,7 @@ func (p *loggerPromise) WithName(l *DelegatingLogger, name string) *loggerPromis
 	res := &loggerPromise{
 		logger:       l,
 		name:         &name,
-		promisesLock: &sync.Mutex{},
+		promisesLock: sync.Mutex{},
 	}
 
 	p.promisesLock.Lock()
@@ -52,7 +52,7 @@ func (p *loggerPromise) WithValues(l *DelegatingLogger, tags ...interface{}) *lo
 	res := &loggerPromise{
 		logger:       l,
 		tags:         tags,
-		promisesLock: &sync.Mutex{},
+		promisesLock: sync.Mutex{},
 	}
 
 	p.promisesLock.Lock()
@@ -130,7 +130,7 @@ func (l *DelegatingLogger) Fulfill(actual logr.Logger) {
 func NewDelegatingLogger(initial logr.Logger) *DelegatingLogger {
 	l := &DelegatingLogger{
 		Logger:  initial,
-		promise: &loggerPromise{promisesLock: &sync.Mutex{}},
+		promise: &loggerPromise{promisesLock: sync.Mutex{}},
 	}
 	l.promise.logger = l
 	return l