PR suggested changes

Signed-off-by: Iván Álvarez <ivanape@inditex.com>
kubernetes-sigs · May 27, 2024 · 2f0deff · 2f0deff
1 parent 9ce51b8
commit 2f0deff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/examples/fleet/main.go b/examples/fleet/main.go
@@ -97,7 +97,7 @@ func main() {
 			if err := client.Get(ctx, req.NamespacedName, pod); err != nil {
 				return reconcile.Result{}, err
 			}
-			log.Info(fmt.Sprintf("Retrieved pod %s:>%s/%s", cl.Name(), pod.Namespace, pod.Name))
+			log.Info("Reconciling pod", "ns", pod.GetNamespace(), "name", pod.Name, "uuid", pod.UID)
 
 			// Print any annotations that start with fleet.
 			for k, v := range pod.Labels {

diff --git a/pkg/manager/internal.go b/pkg/manager/internal.go
@@ -619,6 +619,7 @@ func (cm *controllerManager) Engage(ctx context.Context, cl cluster.Cluster) err
 	// be reentrant via noop
 	cm.engagedClustersLock.RLock()
 	if _, ok := cm.engagedClusters[cl.Name()]; ok {
+		cm.engagedClustersLock.RUnlock()
 		return nil
 	}
 	cm.engagedClustersLock.RUnlock()