Skip to content

Commit

Permalink
📖 Document that indexes can be added after Informer was started
Browse files Browse the repository at this point in the history
The comment is outdated, support for it was added in Kube 1.30, ref
kubernetes/kubernetes#117046
  • Loading branch information
alvaroaleman committed Jun 26, 2024
1 parent 162a113 commit 41c63d0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ type Informer interface {
// This function is guaranteed to be idempotent and thread-safe.
RemoveEventHandler(handle toolscache.ResourceEventHandlerRegistration) error

// AddIndexers adds indexers to this store. If this is called after there is already data
// in the store, the results are undefined.
// AddIndexers adds indexers to this store. It is valid to add indexers
// after an informer was started.
AddIndexers(indexers toolscache.Indexers) error

// HasSynced return true if the informers underlying store has synced.
Expand Down

0 comments on commit 41c63d0

Please sign in to comment.