Skip to content

Commit

Permalink
disable metalinter goimports because it is broken (failing on files t…
Browse files Browse the repository at this point in the history
…hat haven't changed their imports)
  • Loading branch information
pwittrock committed Jan 4, 2019
1 parent 8409bdd commit 58c9cd9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion hack/verify.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ gometalinter.v2 --disable-all \
--enable=structcheck \
--enable=golint \
--enable=deadcode \
--enable=goimports \
--enable=errcheck \
--enable=varcheck \
--enable=goconst \
Expand All @@ -52,6 +51,7 @@ gometalinter.v2 --disable-all \
--skip=atomic \
./pkg/...
# TODO: Enable these as we fix them to make them pass
# --enable=goimports \
# --enable=gosec \
# --enable=maligned \
# --enable=safesql \
Expand Down
2 changes: 1 addition & 1 deletion pkg/builder/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var newController = controller.New
var newManager = manager.New
var getGvk = apiutil.GVKForObject

// Builder builds an Application ControllerManagedBy (e.g. Operator) and returns a manager.Manager to start it.
// Builder builds a Controller.
type Builder struct {
apiType runtime.Object
mgr manager.Manager
Expand Down

0 comments on commit 58c9cd9

Please sign in to comment.